Emit extensions #248
Merged
Emit extensions #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickelectric
requested changes
Aug 4, 2024
|
Looking forward to this as well, thank you |
|
I was originally under the impression storm32 was just overlocked and since it generated a compiler warning I just added it. |
patrickelectric
approved these changes
Aug 22, 2024
|
@pv42 can you rebase over master ? It appears to contain conflicts. |
|
|
pv42
force-pushed
the
emit-extensions-fix
branch
from
d6780ed
to
cdb135e
Compare
pv42
force-pushed
the
emit-extensions-fix
branch
from
cdb135e
to
7942d88
Compare
|
Should be properly rebased now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes emit-extensions and emit-descriptions features not being used by mavlink-bindgen (#246).
This requires a (none breaking) bump in version since fixes in the mavlink crate require newer versions of mavlink-bindgen/mavlink-core crates.
To ensure test work this required adding the path specifications for the dependencies within this crate.
Fixes missing storm32 dialect feature.